Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and phpdoc for initial Optimization Detective release #1078

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Update readme and phpdoc for initial Optimization Detective release #1078

merged 7 commits into from
Mar 22, 2024

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Mar 22, 2024 •
edited
Loading

This updates the readme.txt for Optimization Detective along with some phpdoc fixes for an initial release on the WordPress Plugin Directory. It also fixes a bad condition in a _doing_it_wrong() check.

The bulk of the readme changes are in a Google Doc which will be added here once reviewed.

@westonruter westonruter added no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature [Type] Documentation Documentation to be added or enhanced and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Mar 22, 2024
@westonruter westonruter mentioned this pull request Mar 22, 2024
Merged
2 tasks
@westonruter westonruter marked this pull request as ready for review March 22, 2024 20:18
@westonruter westonruter requested a review from felixarntz as a code owner March 22, 2024 20:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing.

plugins/optimization-detective/detection.php Outdated Show resolved Hide resolved
@westonruter westonruter merged commit ea44fcf into feature/image-loading-optimization Mar 22, 2024
25 checks passed
@westonruter westonruter deleted the update/optimization-detective-readme branch March 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @felixarntz @mukeshpanchal27