-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge trunk into feature/image-loading-optimization #1063
Merge trunk into feature/image-loading-optimization #1063
Conversation
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
…ludes Move `admin` to `includes` directory
Bump minimum required WP version to 6.4
Fix standalone plugin versions and changelogs Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org>
… merge/trunk-into-image-loading-optimization
… merge/trunk-into-image-loading-optimization * 'trunk' of https://github.com/WordPress/performance: Bump Embed Optimizer required WP version to 6.4. Fix other standalone plugin versions with 6.4 bump. Fix Speculation Rules version and changelog.
Remove workflow to test standalone plugins built from modules as no longer relevant Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org>
Support changing autoload value for largest autoloaded options in Site Health check Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org> Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
… merge/trunk-into-image-loading-optimization * 'trunk' of https://github.com/WordPress/performance: Remove workflow to test standalone plugins built from modules as no longer relevant. Remove WP 6.3 from workflow Add unit test Apply suggestions from code review Update approach for modified option Change update option logic Minor adjustments Update parameter name Fix lint Apply suggestions from code review Use action URL approach Use button instead a tag Ensure function returns string Address review feedbacks Update since POC
…to-image-loading-optimization
@felixarntz Now up to date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter With all the merge conflicts, this is difficult to review.
Looking at trunk...merge/trunk-into-image-loading-optimization, I am especially curious about whether the build process is handled efficiently here and whether it needs to run in all the instances where it appears to be run in the feature branch (as far as I know, only optimization-detective
requires a build process at this point because of web-vitals
).
I'm not opposed to blindly approving this to unblock the work, but I would probably raise the same question once an actual PR from the feature branch to trunk
would exist, so doesn't hurt figuring this out already :)
@felixarntz yes, it is difficult to review.
Of the 4 instances, and @thelovekesh would be best to speak to this, it could possibly be omitted from: performance/.github/workflows/php-test.yml Lines 65 to 66 in efb7c1e
and performance/.github/workflows/deploy-dotorg.yml Lines 23 to 24 in efb7c1e
Since the Performance Lab plugin doesn't currently require assets to be built. But it would definitely need to be present in the two other locations, since it is specifically for the standalone plugins, including Optimization Detective and (soon Web Worker Offloading): performance/.github/workflows/php-test-plugins.yml Lines 64 to 65 in efb7c1e
and performance/.github/workflows/deploy-standalone-plugins.yml Lines 37 to 38 in efb7c1e
Maybe we merge this now and then get confirmation when merging into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock this. Let's make sure to iron out the workflow changes before trunk
merge though. This kind of change that affects all other plugins too needs to be carefully evaluated.
0f5f68d
into
feature/image-loading-optimization
Note that this fixes merge conflicts. Pay special attention to changes in these files:
Diff with
trunk
: trunk...merge/trunk-into-image-loading-optimization