Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme: Update pattern workaround to use template filters. #686

Merged
merged 3 commits into from
May 6, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented May 2, 2024

Fixes #662 — This removes the pattern slug filtering in favor of adding extra custom templates, and filtering to inject those into the hierarchy. This is a more core-native way to handle template overrides, so it will be less likely to break in the future. With this change, we can unpin Gutenberg.

Additionally, this fixes the alignment of the "logged out" error messages.

Screenshots

"Before" here is with GB <18, just to show the alignment change.

Before After
gb18-before gb18-after

How to test the changes in this Pull Request:

  1. Update locally to Gutenberg 18+
  2. Be logged out
  3. View the "My patterns" page
  4. It should give you a "please log in" message
  5. Repeat with Favorites, it should also show a "please log in" message
  6. View a pattern you own
  7. There should be a status message above the pattern name and pattern actions (edit, etc) under the preview.

ryelle added 3 commits May 2, 2024 17:41
Fixes #662 — This removes the pattern slug filtering in favor of adding extra custom templates, and filtering to inject those into the hierarchy. This is a more core-native way to handle template overrides, so it will be less likely to break in the future.
@ryelle ryelle added the [Component] Theme The frontend of the pattern directory, pattern lists UI label May 2, 2024
@ryelle ryelle self-assigned this May 2, 2024
@ryelle ryelle merged commit f7ffec0 into trunk May 6, 2024
3 checks passed
@ryelle ryelle deleted the fix/gutenberg-18-compat branch May 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Block theme: Dynamic pattern includes broken with GB 18.1
1 participant