-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spam checking on pattern submissions #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if they don't meet the requirements.
dd32
added
[Component] Pattern Creator
Anything related to the pattern front end editor or preview
[Component] Pattern Directory
The backend of the pattern directory: submission, management, etc
labels
Feb 23, 2022
ryelle
reviewed
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass locally, and on the PR itself. Manually tested as well. I haven't been able to trigger Akismet spamming a pattern, but the other two checks work as expected.
public_html/wp-content/plugins/pattern-directory/includes/pattern-validation.php
Show resolved
Hide resolved
public_html/wp-content/plugins/pattern-directory/includes/pattern-validation.php
Outdated
Show resolved
Hide resolved
ryelle
reviewed
Mar 2, 2022
public_html/wp-content/plugins/pattern-directory/includes/pattern-validation.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/pattern-directory/includes/pattern-validation.php
Outdated
Show resolved
Hide resolved
…from other pending-review posts.
This leaves `$links` in place even though it's not in use, as it's likely needed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Component] Pattern Creator
Anything related to the pattern front end editor or preview
[Component] Pattern Directory
The backend of the pattern directory: submission, management, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some anti-spam checks to pattern submissions:
In order to simplify the text being checked, I leveraged the Pattern Translator codebase to extract all strings from the submitted content, rather than simply passing the HTML to Akismet, to avoid any issues related to HTML.
See #22
How to test the changes in this Pull Request:
PatternDirectorySpamTest
within the content, or the pattern only containingcore/paragraph
blocks)You can also try running
yarn test:php
however I've been unable to run phpunit locally due towp-env
problems, so I'm not able to check the unit test additions actually work.