This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Babel-preset-default: Add new package containing the default Babel configuration #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
youknowriad,
pento,
ntwb,
aduth and
adamsilverstein
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
- Coverage 79.22% 78.52% -0.7%
=========================================
Files 20 21 +1
Lines 337 340 +3
Branches 70 71 +1
=========================================
Hits 267 267
- Misses 59 61 +2
- Partials 11 12 +1
Continue to review full report at Codecov.
|
ntwb
suggested changes
Jan 21, 2018
packages/scripts/package.json
Outdated
| @@ -30,8 +30,7 @@ | |||
| "devDependencies": { | |||
| "babel-jest": "^22.0.4", | |||
| "cross-spawn": "5.1.0", | |||
| "jest": "^22.0.4", | |||
| "regenerator-runtime": "^0.11.1" | |||
There was a problem hiding this comment.
Unrelated change, this shouldn't be in this PR, it should be updated by removing it in #62
| @@ -1,7 +1,6 @@ | |||
| // Do this as the first thing so that any code reading it knows the right env. | |||
| process.env.BABEL_ENV = 'test'; | |||
| process.env.NODE_ENV = 'test'; | |||
| process.env.PUBLIC_URL = ''; | |||
There was a problem hiding this comment.
Unrelated change, this shouldn't be in this PR, it should be updated by removing it in #62
gziolo
force-pushed
the
add/scripts-jest
branch
from
7b7de10 to
f72dda2
Compare
gziolo
force-pushed
the
add/babel-preset
branch
2 times, most recently
from
ea9b5d9 to
b929481
Compare
gziolo
force-pushed
the
add/babel-preset
branch
from
b929481 to
e20ff67
Compare
ntwb
approved these changes
Jan 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #62.
This PR extract Babel configuration which is going to be shared between
packagesandGutenberginto its own package.It should be tested similarly to #62. We need to make sure that all existing commands work as before:
npm testnpm run buildAgain, I don't think we need unit tests for this new package as it tests itself because this preset is used by the aforementioned commands.