This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Improve publishing process #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
force-pushed
the
update/improve-publishing-process
branch
from
ab35d7a
to
9af1934
Compare
aduth
approved these changes
Apr 25, 2018
| const config = require( packageFile ); | ||
| if ( ! config.publishConfig || 'public' !== config.publishConfig.access ) { | ||
| process.stdout.write( `${ ERROR } package.json must include "publishConfig": { "access": "public" }\n` ); | ||
| process.exitCode = 1; |
There was a problem hiding this comment.
I think with this usage, the script will continue to run, but exit with a code of 1? vs. process.exit( 1 ) which terminates immediately.
There was a problem hiding this comment.
Yah, I figured it was fine to let it run to completion, so you see build errors for all modules, if there are multiple.
CONTRIBUTING.md
Outdated
|
|
||
| ### Development release | ||
|
|
||
| Run the following command to release a dev version of the outdated packages: | ||
| Run the following command to release a dev version of the outdated packages, replacing "123456" with your 2FA code: |
There was a problem hiding this comment.
It may be worth making a note that since publishing can take some time, it is good to ensure that the one-time code still has a decent duration remaining before starting the process. Made more cumbersome by the fact that the developer needs to navigate through the publishing options before publishing starts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the documentation for the package release process.
publishConfigsettings before publishing new packages.This also adds a check for
"publishConfig": { "access": "public" }being set in each module'spackage.json.npm run buildwill fail (causing Travis, and publishing to fail) if it isn't set.