Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ingestion_server as a known first party for isort #965

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

raiyaj
Copy link
Contributor

@raiyaj raiyaj commented Mar 20, 2023

Fixes

Related to #337 by @AetherUnbound

Description

This makes ingestion_server as an explicit known first party for isort, so that third party imports will be placed above first party imports.

Testing Instructions

Rearrange the imports in a file under ingestion_server (so that a third party import comes after a first party import), then run just lint isort. That should fix the import order :)

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@raiyaj raiyaj requested a review from a team as a code owner March 20, 2023 18:57
@raiyaj raiyaj requested review from obulat and stacimc March 20, 2023 18:57
@raiyaj raiyaj changed the title configure ingestion_server as a known first party for isort Configure ingestion_server as a known first party for isort Mar 20, 2023
@openverse-bot openverse-bot added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: backend labels Mar 20, 2023
@AetherUnbound
Copy link
Collaborator

AetherUnbound commented Mar 20, 2023

Thank you @raiyaj!! There is another aspect of this issue that Raiya is working on for the catalog as well 🙂 So the merging of this PR won't close the issue but the merging of both this and the catalog PR will!

Also we discussed in person - this doesn't change any code because isort seems to be handling the ingestion server as a third party appropriately, but being explicit should help nonetheless 🚀

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!

Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @raiyaj

@sarayourfriend sarayourfriend merged commit 34d14ec into WordPress:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants