-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to staging automatically on release #883
Conversation
Full-stack documentation: Ready https://WordPress.github.io/openverse/_preview/883 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Will we be cutting releases in the future? I'm not opposed to the idea but I thought that was no longer possible due to the out-of-sync release cadence of the projects inside the monorepo. |
We will! We'll just be able to selectively deploy a release against either the prod frontend or API (or both) at our own discretion 🙂 |
I'm not necessarily opposed to this, but I'm not understanding what it is for. No rush but could you explain the motivation somewhere @AetherUnbound? |
I believe the previous behavior for the frontend was that, when a release was cut, the frontend would automatically be deployed at that tag. This PR maintains that behavior and also applies it to the API as well. The alternative would be for us to manually deploy a release tag to staging come on which seems unnecessarily manual IMO. |
@AetherUnbound the main issue with releases is that it will tag the entire codebase at a particular commit (every layer of the stack). Apologies if I'm misunderstanding, but it seems that with this change, we will be deploying every layer on every release, in sync, with the same version number, even if nothing has changed or something is incomplete? |
I think a point of clarification would be that we will be deploying every layer to staging on every release, in sync, with the same version number, even if nothing has changed. Even if something is incomplete, we already deploy both the frontend and API to staging on every push to |
Just noting that some of this is ideologically conflicting with #895 which tries to skip as many steps as possible (including image building and publishing) if files haven't changed. |
Ahh, that's an interesting point. I think it makes sense to build & push images for all services when a release is made, though now that you mention the job skipping I'm not even sure that'd happen with our workflows the way they're currently set up 😅 I guess it depends on how |
We discussed this publicly here and will be going with an alternative approach: https://wordpress.slack.com/archives/C02012JB00N/p1678808559132249 |
Description
This is a small change to the CI/CD workflow to automatically initiate a deployment to staging when a release is cut.
Testing Instructions
N/A
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin