Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry; fix config #870

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Update sentry; fix config #870

merged 2 commits into from
Mar 9, 2023

Conversation

zackkrida
Copy link
Member

Description

Updates the Sentry SDK and updates it to allow errors from openverse.org. Currently the Sentry SDK is way out of date on the frontend and not accepting events from openverse.org. This PR updates the SDK and fixed the allowed domains.

Testing Instructions

I actually need help from @WordPress/openverse-frontend on the best way to test this.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 8, 2023 14:59
@zackkrida zackkrida requested review from obulat and dhruvkb March 8, 2023 14:59
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 8, 2023
frontend/src/utils/sentry-config.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/870

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: frontend Related to the Nuxt frontend 🛠 goal: fix Bug fix and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 8, 2023
@zackkrida zackkrida requested a review from krysal March 8, 2023 16:27
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@krysal krysal added 🧱 stack: frontend Related to the Nuxt frontend and removed 🧱 stack: frontend Related to the Nuxt frontend labels Mar 9, 2023
@krysal krysal merged commit 7208787 into main Mar 9, 2023
@krysal krysal deleted the update-sentry-sdk branch March 9, 2023 21:50
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
* Retired module commoncrawl and retired the commoncrawl_utils test

* updated DAGs.md and test_dag_parsing.py as suggested in ##861

* Remove ETL test module, additional documentation cleanup

* Delete more unused test files

* Remove unused testing buckets

* Update README.md

Co-authored-by: Olga Bulat <[email protected]>

Co-authored-by: Meet Parekh <[email protected]>
Co-authored-by: Meet Parekh <[email protected]>
Co-authored-by: Olga Bulat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants