Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp to last patch version 3.11.11 #5328

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 11, 2025

Fixes

This update might help address the memory leak problem. This PR is based on the Python update PR (#5327)

Description

Here's the summary from ChatGPT of why upgrading might help solve memory leak problems:

A critical bugfix that affects streaming downloads:

  • Fixed Paused Connections on Streaming (#10169):
    There was a bug where connections used for streaming downloads could return to the pool in a paused state. Even though we don’t iterate over chunks manually, calling await upstream_response.content.read() in the thumbnail is still “streaming” under the hood. This could lead to connections remaining half-open, causing a buildup of idle connections and potentially leading to memory or resource leaks.

  • Improved Keep-Alive and force_close Handling:
    In various 3.11.x patches, aiohttp improved how connections are reused and cleaned up (e.g. #9997, #10003). These changes help ensure connections won’t remain stuck in the pool if force_close or keep-alive logic isn’t handled properly.

By upgrading to aiohttp 3.11.11, we expect to see improved stability and fewer issues with unclosed or “paused” connections in our thumbnail service.

Testing Instructions

Merge, deploy, wait and see

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 11, 2025
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 11, 2025
@obulat obulat force-pushed the update/aiohttp-3.11.11 branch from 81d0001 to b201b47 Compare January 11, 2025 12:51
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Paused Connections on Streaming (aio-libs/aiohttp#10169):
There was a bug where connections used for streaming downloads could return to the pool in a paused state. Even though we don’t iterate over chunks manually, calling await upstream_response.content.read() in the thumbnail is still “streaming” under the hood. This could lead to connections remaining half-open, causing a buildup of idle connections and potentially leading to memory or resource leaks.

Very interesting context. Thanks for sharing! This looks good to me if you want to mark it as ready and deploy as well.

@obulat obulat force-pushed the update/aiohttp-3.11.11 branch from b201b47 to af44d0a Compare January 12, 2025 06:30
@obulat obulat marked this pull request as ready for review January 12, 2025 06:30
@obulat obulat requested a review from a team as a code owner January 12, 2025 06:30
@obulat obulat requested review from krysal and dhruvkb and removed request for a team January 12, 2025 06:30
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promising and hopeful!

@obulat obulat merged commit 60eef23 into main Jan 12, 2025
55 checks passed
@obulat obulat deleted the update/aiohttp-3.11.11 branch January 12, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

4 participants