Update aiohttp
to last patch version 3.11.11
#5328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This update might help address the memory leak problem. This PR is based on the Python update PR (#5327)
Description
Here's the summary from ChatGPT of why upgrading might help solve memory leak problems:
A critical bugfix that affects streaming downloads:
Fixed Paused Connections on Streaming (#10169):
There was a bug where connections used for streaming downloads could return to the pool in a paused state. Even though we don’t iterate over chunks manually, calling
await upstream_response.content.read()
in the thumbnail is still “streaming” under the hood. This could lead to connections remaining half-open, causing a buildup of idle connections and potentially leading to memory or resource leaks.Improved Keep-Alive and
force_close
Handling:In various 3.11.x patches, aiohttp improved how connections are reused and cleaned up (e.g. #9997, #10003). These changes help ensure connections won’t remain stuck in the pool if
force_close
or keep-alive logic isn’t handled properly.By upgrading to aiohttp 3.11.11, we expect to see improved stability and fewer issues with unclosed or “paused” connections in our thumbnail service.
Testing Instructions
Merge, deploy, wait and see
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin