-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required variables for Nuxt Sentry setup #5284
Conversation
Latest k6 run output1
Footnotes
|
Full-stack documentation: https://docs.openverse.org/_preview/5284 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
f5aa192
to
0cafbed
Compare
0752b91
to
62126de
Compare
42d1620
to
bb750c4
Compare
bb750c4
to
b2b3622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes
Follow up on #5279
Description
This pull request updates the Docker build process to address an issue with environment variables not being properly read by Sentry during image builds. This prevented the source maps from being created and sent to Sentry. The
release
also wasn't set, so the source maps did not work.In our CI pipeline, when a pull request is merged into the main branch, the process builds a Docker image that will then be deployed to production. We need to generate the source maps and release for this image, and not other builds.
To generate and upload the source maps and release, Sentry needs the auth token. This is set in CI only on the push to main (when a PR is merged) or when release is triggered manually through the Actions GUI. This way, the source maps are generated and sent to Sentry only once per PR.
Setting the release name also did not work with the env variable, only using the
sentry.unstable_sentryBundlerPluginOptions
properties innuxt.config.ts
did 1.With these changes, I also removed some locales setup from theInstead of removing the locale setup fromsetup-env
, because they are set up second time during the build of the app - so duplicated unnecessarily.setup-env
, I removed it from the Dockerfile.Testing Instructions
You can see the run that did set an auth token (because I inverted the condition for variable), and built the sourcemaps and uploaded them to Sentry: https://github.com/WordPress/openverse/actions/runs/12387322051/job/34576691827?pr=5284
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin
Footnotes
[Nuxt] Cannot set release name used by sentry-vite-plugin ↩