Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the image and audio result components #5272

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 11, 2024

Fixes

Fixes #5271 by @obulat

Description

This PR aims to standardize the two components:

  • the names are now <MediaType>Result
  • href for the link to the single result page is computed in VImageResult and VAudioResult (instead of VAudioTrack, as before)

Testing Instructions

The search result components should work correctly for All media, Image, and Audio views, and should have correct URLs linking to the single result page.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat force-pushed the unify-image-audio-results branch from 95082be to 47ea327 Compare December 11, 2024 18:28
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon 🧰 goal: internal improvement Improvement that benefits maintainers, not users 💻 aspect: code Concerns the software code in the repository labels Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 408      ✗ 0   
     data_received..................: 95 MB   393 kB/s
     data_sent......................: 53 kB   222 B/s
     http_req_blocked...............: avg=60.35µs  min=2.33µs  med=4.8µs    max=1.28ms p(90)=150.49µs p(95)=233.27µs
     http_req_connecting............: avg=31.55µs  min=0s      med=0s       max=1.24ms p(90)=93.97µs  p(95)=130.08µs
     http_req_duration..............: avg=205.42ms min=32.65ms med=157.19ms max=1.35s  p(90)=389.2ms  p(95)=444.52ms
       { expected_response:true }...: avg=205.42ms min=32.65ms med=157.19ms max=1.35s  p(90)=389.2ms  p(95)=444.52ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 408 
     http_req_receiving.............: avg=171.24µs min=63.64µs med=140.74µs max=2.54ms p(90)=285.11µs p(95)=331.07µs
     http_req_sending...............: avg=24.39µs  min=7.33µs  med=22.69µs  max=93.7µs p(90)=33.23µs  p(95)=42.31µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s     p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=205.23ms min=32.5ms  med=157.07ms max=1.35s  p(90)=388.92ms p(95)=444.21ms
     http_reqs......................: 408     1.693188/s
     iteration_duration.............: avg=1.11s    min=477.9ms med=1.17s    max=2.45s  p(90)=1.43s    p(95)=1.79s   
     iterations.....................: 76      0.315398/s
     vus............................: 2       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat force-pushed the unify-image-audio-results branch from 47ea327 to 1b6e6b8 Compare December 12, 2024 10:20
@obulat obulat marked this pull request as ready for review December 12, 2024 14:56
@obulat obulat requested a review from a team as a code owner December 12, 2024 14:56
@obulat obulat requested review from krysal and dhruvkb December 12, 2024 14:56
@obulat obulat force-pushed the unify-image-audio-results branch 2 times, most recently from c88fb09 to 9f9d614 Compare December 13, 2024 05:07
@obulat obulat force-pushed the unify-image-audio-results branch from 9f9d614 to 766de3c Compare December 13, 2024 05:19
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a small non-blocking suggestion.

@obulat obulat merged commit 87ce0b3 into main Dec 15, 2024
50 checks passed
@obulat obulat deleted the unify-image-audio-results branch December 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Standardize the image and audio result components
3 participants