-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the image and audio result components #5272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
force-pushed
the
unify-image-audio-results
branch
from
December 11, 2024 18:28
95082be
to
47ea327
Compare
openverse-bot
added
🧱 stack: frontend
Related to the Nuxt frontend
🟨 priority: medium
Not blocking but should be addressed soon
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
💻 aspect: code
Concerns the software code in the repository
labels
Dec 11, 2024
Latest k6 run output1
Footnotes
|
obulat
force-pushed
the
unify-image-audio-results
branch
from
December 12, 2024 10:20
47ea327
to
1b6e6b8
Compare
obulat
force-pushed
the
unify-image-audio-results
branch
2 times, most recently
from
December 13, 2024 05:07
c88fb09
to
9f9d614
Compare
obulat
force-pushed
the
unify-image-audio-results
branch
from
December 13, 2024 05:19
9f9d614
to
766de3c
Compare
dhruvkb
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a small non-blocking suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #5271 by @obulat
Description
This PR aims to standardize the two components:
<MediaType>Result
href
for the link to the single result page is computed inVImageResult
andVAudioResult
(instead ofVAudioTrack
, as before)Testing Instructions
The search result components should work correctly for All media, Image, and Audio views, and should have correct URLs linking to the single result page.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin