-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nuxi typecheck
to make the frontend types check in pre-commit faster
#5268
Conversation
Latest k6 run output1
Footnotes
|
351769c
to
64dd549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, as someone who commits frequently, this will save a lot of time.
@@ -109,7 +109,7 @@ repos: | |||
- id: types | |||
name: types | |||
files: ^(frontend|packages/js)/.*$ | |||
entry: bash -c 'pnpm run prepare:nuxt && pnpm run -r types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really get why a lot of language: system
hooks have followed the bash -c ''
notation so I support this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that either, but it works without it :)
Fixes
Tiny fix I noticed when testing the
ov
PR.Description
This PR replaces several commands we use for type testing with the Nuxt's
nuxi typecheck
, which generates the types in the.nuxt
folder, and then runs the checks.Previously, we were running
nuxi prepare
(which runs more steps than simply creating the types) twice in the precommit check.Testing Instructions
The typecheck in the CI should pass.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin