Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dev and test dependencies of the API #5249

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Bump dev and test dependencies of the API #5249

merged 2 commits into from
Dec 4, 2024

Conversation

krysal
Copy link
Member

@krysal krysal commented Dec 4, 2024

Description

For some reason, dependabot is not detecting these dependencies (see the list in #255), so I'm doing it here.

Testing Instructions

Confirm the API continues to run normally.
Watch the CI workflow passing.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Dec 4, 2024
@krysal krysal requested a review from a team as a code owner December 4, 2024 15:57
@krysal krysal requested review from obulat and dhruvkb and removed request for a team December 4, 2024 15:57
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the renovate logs, you will see something related to poetry missing in the pyproject.toml, even though we are using pdm. Maybe adding that setti g in would fix it...

Base automatically changed from bump_1 to main December 4, 2024 16:51
@krysal
Copy link
Member Author

krysal commented Dec 4, 2024

@obulat, which setting are you referring to? It shouldn't need poetry since we are not using it. Maybe completely disabling it would help. Definitely it's worth a try.

@krysal krysal merged commit 4a7a862 into main Dec 4, 2024
54 checks passed
@krysal krysal deleted the bump_2 branch December 4, 2024 18:21
@obulat
Copy link
Contributor

obulat commented Dec 4, 2024

@krysal, after a long-ish investigation, I found that those warnings were a red herring. The problem is that the way we write the versions is not compliant with PEP 440 because we add spaces in the versions. Here's an example of correct versions:

https://github.com/renovatebot/renovate/blob/ffeaef099f74323fd4d7bd5367d8002c1520dc89/lib/modules/manager/pep621/__fixtures__/pyproject_with_pdm.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants