Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change text to secondary on content-heavy pages #5148

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Change text to secondary on content-heavy pages #5148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
128d292
Change text to secondary on content-heavy pages
dhruvkb Nov 5, 2024
2c6a36e
Only apply `text-secondary` in dark mode
dhruvkb Nov 11, 2024
a091131
Merge branch 'main' of github.com:WordPress/openverse into text_heavy…
dhruvkb Nov 11, 2024
abac8a1
Run tests with 0 diff pixels
dhruvkb Nov 11, 2024
f097244
Update test criteria to fail
dhruvkb Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/VContentPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { skipToContentTargetId } from "~/constants/window"
dir="ltr"
>
<div
class="prose-h1:text-bold prose-body:text-default prose-sm mx-auto mb-10 max-w-none px-6 text-default md:prose-base prose-headings:font-bold prose-headings:text-default prose-h1:text-4xl prose-h2:text-2xl prose-h2:font-semibold prose-h3:text-2xl prose-h3:font-semibold prose-a:font-medium md:max-w-4xl md:prose-h1:mb-10 md:prose-h2:mt-10 md:prose-h3:mt-10 lg:mb-30 lg:px-0 lg:prose-headings:text-3xl lg:prose-h1:text-6xl xl:max-w-5xl"
class="prose-h1:text-bold prose-sm mx-auto mb-10 max-w-none px-6 md:prose-base prose-headings:font-bold prose-headings:text-default prose-h1:text-4xl prose-h2:text-2xl prose-h2:font-semibold prose-h3:text-2xl prose-h3:font-semibold prose-a:font-medium md:max-w-4xl md:prose-h1:mb-10 md:prose-h2:mt-10 md:prose-h3:mt-10 lg:mb-30 lg:px-0 lg:prose-headings:text-3xl lg:prose-h1:text-6xl xl:max-w-5xl dark:text-secondary"
>
<slot default />
</div>
Expand Down
5 changes: 5 additions & 0 deletions frontend/test/playwright/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ const config: PlaywrightTestConfig = {
* to avoid the test also becoming a load test.
*/
workers: UPDATE_TAPES === "true" || baseURL !== localBaseURL ? 1 : undefined,
expect: {
toMatchSnapshot: {
threshold: 0.1,
},
},
}

export default config
4 changes: 1 addition & 3 deletions frontend/test/playwright/visual-regression/pages/pages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ for (const contentPage of contentPages) {
await expectSnapshot(page, contentPage, page, {
dir,
screenshotOptions: { fullPage: true },
snapshotOptions: { maxDiffPixelRatio: 0.01 },
})
})
})
Expand Down Expand Up @@ -100,8 +99,7 @@ test.describe("layout color is set correctly", () => {
await page.mouse.move(100, 100)

expect(await page.screenshot({ fullPage: true })).toMatchSnapshot(
"about-ltr-lg-light.png",
{ maxDiffPixelRatio: 0.01 }
"about-ltr-lg-light.png"
)
})
})
Expand Down
Loading