Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node and pnpm #5084

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Update node and pnpm #5084

merged 1 commit into from
Oct 26, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 26, 2024

Fixes

Necessary for Storybook Playwright tests to build and pass. See failure in https://github.com/WordPress/openverse/actions/runs/11529074974/job/32097106744?pr=5025

Description

This PR updates the node version to v.22 (which is supposed to become LTS in October 2024), and also updates pnpm

Testing Instructions

Run ov clean and ov init to make sure that your ov node version is updated. Then, all the JS/TS code should work as usual.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 26, 2024
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 26, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  8.8 MB/s
     data_sent......................: 837 kB  5.0 kB/s
     http_req_blocked...............: avg=13.69µs  min=1.99µs   med=3.61µs   max=8.01ms  p(90)=5.15µs   p(95)=5.57µs  
     http_req_connecting............: avg=9.35µs   min=0s       med=0s       max=7.97ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=586.3ms  min=37.94ms  med=514.4ms  max=2.39s   p(90)=1.06s    p(95)=1.15s   
       { expected_response:true }...: avg=586.3ms  min=37.94ms  med=514.4ms  max=2.39s   p(90)=1.06s    p(95)=1.15s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=141.36µs min=42.39µs  med=111.4µs  max=29.25ms p(90)=175.96µs p(95)=207.24µs
     http_req_sending...............: avg=20.29µs  min=7.17µs   med=18.92µs  max=2.2ms   p(90)=24.98µs  p(95)=27.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=586.14ms min=37.78ms  med=514.26ms max=2.39s   p(90)=1.06s    p(95)=1.15s   
     http_reqs......................: 6400    37.862442/s
     iteration_duration.............: avg=3.13s    min=767.14ms med=2.59s    max=8.48s   p(90)=6.09s    p(95)=6.44s   
     iterations.....................: 1200    7.099208/s
     vus............................: 3       min=3       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat marked this pull request as ready for review October 26, 2024 06:58
@obulat obulat requested a review from a team as a code owner October 26, 2024 06:58
@obulat obulat requested a review from krysal October 26, 2024 06:58
@obulat obulat merged commit 3078831 into main Oct 26, 2024
54 checks passed
@obulat obulat deleted the update/node-pnpm branch October 26, 2024 06:58
@obulat obulat mentioned this pull request Oct 28, 2024
8 tasks
Danil49 pushed a commit to Danil49/openverse that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants