Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Openverse ESLint plugin to FlatConfig #5049

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 18, 2024

Fixes

Fixes #4923 by @obulat

Description

This PR migrates the Openverse ESLint plugin to the FlatConfig that is used in ESLint version 9.

With this update, we remove many deprecated dependencies, improving security.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat force-pushed the update/openverse-eslint-plugin branch from dfe3263 to 7869270 Compare October 18, 2024 15:47
Copy link

github-actions bot commented Oct 18, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.9 GB  8.7 MB/s
     data_sent......................: 1.0 MB  4.9 kB/s
     http_req_blocked...............: avg=13.19µs  min=1.95µs  med=3.68µs   max=6.63ms  p(90)=5.2µs    p(95)=5.54µs  
     http_req_connecting............: avg=9.05µs   min=0s      med=0s       max=6.58ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=555.58ms min=37.2ms  med=501ms    max=2.28s   p(90)=1.03s    p(95)=1.14s   
       { expected_response:true }...: avg=555.58ms min=37.2ms  med=501ms    max=2.28s   p(90)=1.03s    p(95)=1.14s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=151.19µs min=42.54µs med=110.28µs max=28.97ms p(90)=177.47µs p(95)=221.16µs
     http_req_sending...............: avg=22.29µs  min=6.28µs  med=19.1µs   max=5.27ms  p(90)=24.63µs  p(95)=26.86µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=555.4ms  min=37.08ms med=500.88ms max=2.28s   p(90)=1.03s    p(95)=1.14s   
     http_reqs......................: 8000    37.301846/s
     iteration_duration.............: avg=3.71s    min=1.05s   med=3s       max=11.77s  p(90)=7.95s    p(95)=8.52s   
     iterations.....................: 1200    5.595277/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat mentioned this pull request Oct 18, 2024
1 task
@obulat obulat force-pushed the update/openverse-eslint-plugin branch from 55057e1 to 5e81870 Compare October 18, 2024 16:38
@obulat obulat self-assigned this Oct 18, 2024
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 18, 2024
@openverse-bot openverse-bot added the 🧱 stack: mgmt Related to repo management and automations label Oct 18, 2024
@obulat obulat force-pushed the update/openverse-eslint-plugin branch 3 times, most recently from 13f5cdd to 7787e6c Compare October 19, 2024 04:36
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat force-pushed the update/openverse-eslint-plugin branch from 7787e6c to b4208ea Compare October 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Update the @openverse/eslint-plugin to use ESLint v.9
2 participants