Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WP Photo Directory DAG #5038

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix WP Photo Directory DAG #5038

merged 2 commits into from
Oct 14, 2024

Conversation

sarayourfriend
Copy link
Collaborator

Description

I was trying this DAG locally and getting zero results every time. It turns out the format query parameter breaks the response entirely:

This is empty: https://wordpress.org/photos/wp-json/wp/v2/photos?format=json

Whereas this works fine and returns JSON every time: https://wordpress.org/photos/wp-json/wp/v2/photos

Removing the format query parameter from the DAG fixes the issue.

Testing Instructions

Run the DAG on main and confirm you get zero results in pull_image_data.

Run the DAG on this branch, and confirm you now get the full result set.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Oct 12, 2024
@sarayourfriend sarayourfriend requested a review from a team as a code owner October 12, 2024 20:41
@sarayourfriend sarayourfriend requested review from obulat and stacimc and removed request for a team October 12, 2024 20:41
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Sara! I modified the tests so the CI passes. Thank you!

I noticed in the notifications Slack channel that only the last two runs brought nothing. So this is relatively recent, but it raises the need to detect this kind of issue if it continues to happen with other DAGs.

@krysal krysal merged commit 5685f88 into main Oct 14, 2024
46 checks passed
@krysal krysal deleted the fix/wp-photo-directory branch October 14, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

2 participants