-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Storybook and pin Nuxt Storybook module version #5025
base: main
Are you sure you want to change the base?
Conversation
91443f4
to
d83672a
Compare
d83672a
to
b3f7b9b
Compare
Latest k6 run output1
Footnotes
|
81254a6
to
d5dffda
Compare
d5dffda
to
e5fd58c
Compare
Full-stack documentation: https://docs.openverse.org/_preview/5025 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
f8610ec
to
20344f3
Compare
20344f3
to
77634c6
Compare
Fixes
Fixes #4963 by @sarayourfriend
Description
Now that the Nuxt Storybook module has released a stable release that works with Openverse, we can pin its version, and update the module's dependencies to match it.
This PR also sets the default port for Storybook in dev mode to match that of the production mode.
When re-running the Storybook in dev mode, you could get
SyntaxError: Unexpected token 'export'
before, so I added cleanup step that removes the.nuxt
folder and fixes this issue.Testing Instructions
The Storybook tests in the CI should pass.
Run
ov just frontend/run dev
. This should run the Storybook in dev mode athttp://localhost:54000
.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin