Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plausible to fix logging #5023

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update plausible to fix logging #5023

merged 1 commit into from
Oct 8, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 7, 2024

Fixes

Fixes #4949 by @zackkrida

Description

This PR updates Plausible packages to fix the logging issue.

Testing Instructions

Run the app using ov just frontend/run dev, and change the media type using the homepage search bar. You should see the analytics event logged in the console.
Build the app, run it, and change the media type. You should not see the analytics events being logged.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat self-assigned this Oct 7, 2024
@obulat obulat requested a review from a team as a code owner October 7, 2024 18:55
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Latest k6 run output1

$     ✗ status was 200
      ↳  99% — ✓ 7996 / ✗ 4

     checks.........................: 99.95% ✓ 7996     ✗ 4   
     data_received..................: 1.8 GB 8.4 MB/s
     data_sent......................: 1.0 MB 4.9 kB/s
     http_req_blocked...............: avg=26.53µs  min=2.01µs  med=3.84µs   max=16.74ms p(90)=5.39µs   p(95)=5.83µs  
     http_req_connecting............: avg=22.28µs  min=0s      med=0s       max=16.71ms p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=558.32ms min=41.47ms med=500.6ms  max=2.38s   p(90)=1.04s    p(95)=1.15s   
       { expected_response:true }...: avg=558ms    min=41.47ms med=500.57ms max=2.38s   p(90)=1.04s    p(95)=1.15s   
   ✓ http_req_failed................: 0.05%  ✓ 4        ✗ 7996
     http_req_receiving.............: avg=142.21µs min=39.27µs med=113.75µs max=13.08ms p(90)=179.77µs p(95)=215.67µs
     http_req_sending...............: avg=22.79µs  min=6.78µs  med=19.81µs  max=16.11ms p(90)=25.64µs  p(95)=27.69µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=558.15ms min=41.34ms med=500.45ms max=2.38s   p(90)=1.04s    p(95)=1.15s   
     http_reqs......................: 8000   37.10507/s
     iteration_duration.............: avg=3.73s    min=1.22s   med=3.14s    max=10.98s  p(90)=8.08s    p(95)=8.59s   
     iterations.....................: 1200   5.565761/s
     vus............................: 6      min=6      max=30
     vus_max........................: 30     min=30     max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit af35381 into main Oct 8, 2024
46 checks passed
@obulat obulat deleted the fix/plausible-logging branch October 8, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Analytics events are not logging in local development (or on staging)
3 participants