Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sentry init log and ignore non-actionable error #4997

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 26, 2024

Fixes

Fixes #4713 by @krysal
Fixes #4788 by @zackkrida

Description

This PR removes the extra logging and adds ResizeObserver error to the ignored list. It was on the ignored list before Nuxt 3 migration.

Testing Instructions

The CI should pass. Try running the app (or look into the CI logs), the Sentry init step should not log the integration list, only the dsn, release and environment.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase labels Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  8.5 MB/s
     data_sent......................: 1.0 MB  4.9 kB/s
     http_req_blocked...............: avg=8.57µs   min=1.7µs   med=3.82µs   max=3.95ms  p(90)=5.45µs   p(95)=5.88µs 
     http_req_connecting............: avg=3.99µs   min=0s      med=0s       max=3.88ms  p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=550.29ms min=59.08ms med=493.56ms max=2.21s   p(90)=1.03s    p(95)=1.15s  
       { expected_response:true }...: avg=550.29ms min=59.08ms med=493.56ms max=2.21s   p(90)=1.03s    p(95)=1.15s  
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=157.69µs min=41.41µs med=116.57µs max=20.82ms p(90)=192.73µs p(95)=240µs  
     http_req_sending...............: avg=24.88µs  min=6.25µs  med=19.27µs  max=8.38ms  p(90)=26.54µs  p(95)=33.89µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=550.1ms  min=58.98ms med=493.42ms max=2.21s   p(90)=1.03s    p(95)=1.15s  
     http_reqs......................: 8000    37.602253/s
     iteration_duration.............: avg=3.67s    min=1.15s   med=3.3s     max=11.37s  p(90)=7.96s    p(95)=8.54s  
     iterations.....................: 1200    5.640338/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat marked this pull request as ready for review September 26, 2024 17:05
@obulat obulat requested a review from a team as a code owner September 26, 2024 17:05
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obulat obulat merged commit 47f44f8 into main Oct 7, 2024
46 checks passed
@obulat obulat deleted the fix/sentry-init-log branch October 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Frontend dev server logs verbose sentry config ResizeObserver loop limit exceeded
3 participants