Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Katmai NPS source from Flickr #4971

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add Katmai NPS source from Flickr #4971

merged 1 commit into from
Sep 23, 2024

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Part of #4856 by @sarayourfriend

Description

This PR adds Katmai National Park Service as a flickr-based source. https://www.flickr.com/photos/99350217@N03

I will kick off a batched update to backfill existing works from Katmai with the new source string.

Testing Instructions

Confirm I have the creator ID correct, I don't think there's anything else to test, though you can run Flickr ingestion locally with these "additional query params" and check that source is set to katmai_nps:

{
        "max_upload_date": 1701349200,
        "min_upload_date": 1690812000,
        "user_id": "99350217@N03"
}

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner September 20, 2024 22:31
@sarayourfriend sarayourfriend requested review from krysal and stacimc and removed request for a team September 20, 2024 22:31
@openverse-bot openverse-bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 20, 2024
@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🗄️ aspect: data Concerns the data in our catalog and/or databases and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 20, 2024
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Don't forget that before these images go live katmai_nps will need to be added as a "Content source" in the Django admin UI.

@sarayourfriend
Copy link
Collaborator Author

Yep! I almost went ahead and added it in production before, but was worried about it appearing in the stats list with 0 images. I wonder if we could filter those, at least in the frontend sources page, so that we can "preload" sources before they have any data available?

@sarayourfriend sarayourfriend merged commit 8c412c6 into main Sep 23, 2024
69 of 79 checks passed
@sarayourfriend sarayourfriend deleted the add/katmai branch September 23, 2024 22:19
sarayourfriend added a commit that referenced this pull request Sep 23, 2024
…y in should (#4978)

* Add utori to the "Made with Openverse" page

dd Sutori to the "Made with Openverse" page.

* Add Sutori to the "Made with Openverse" page.

* Add Sutori to Made with Openverse page (#4972)

Fixed commit message to be more precise and include the issue number

* Add Sutori to Made with Openverse page (#4972)

Fixed commit message to be more precise and include the issue number

* Add Sutori to Made with Openverse page (#4972)

* Add Sutori to Made with Openverse page (#4972)

* @dryruffiaAdd Sutori to Made with Openverse page (#4972)

I added the suggestion from @sarayourfriend.

Co-authored-by: sarayourfriend <[email protected]>

* Add Sutori to Made with Openverse page (#4971)

* Change "exact match boost" implementation to use a match_phrase query in should #4960

I have added support for "match_pharse"
and also removed variable quotes_stripped it's not needed now.

* Changed exact match boost implementation to use a match_phrase query in should #4960

I have added support for "match_pharse"
and also removed variable quotes_stripped it's not needed now.

* I have added support for match_pharse
and also removed variable quotes_stripped it's not needed now.

* Added Test to acoomodate match_pharses

* Added Test to acoomodate match_pharses

* Added Test to accommodate march_phrases

---------

Co-authored-by: sarayourfriend <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄️ aspect: data Concerns the data in our catalog and/or databases 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants