Simplify audiowaveform installation in API Dockerfile #4942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4680 by @sarayourfriend
Description
Simplify the audiowaveform installation in the API Dockerfile by using audiowaveform's published deb packages from their GitHub releases, as discussed in the linked issue.
Pinging @dhruvkb for review because of his familiarity with this to begin with, plus I need to make sure that someone on macOS (an arm64 computer, really) tests this.
Testing Instructions
Checkout the branch and run
ov j build web && ov j up --force-recreate
. Thenov j api/dj generatewaveforms --max_records=2
and confirm that waveforms are successfully generated for 2 audio files. If you already have waveforms for all audio files, you'll need to remove them manually (left up to you) or start over with API test data usingov j down -v && ov j api/init
.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin