Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify audiowaveform installation in API Dockerfile #4942

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Fixes #4680 by @sarayourfriend

Description

Simplify the audiowaveform installation in the API Dockerfile by using audiowaveform's published deb packages from their GitHub releases, as discussed in the linked issue.

Pinging @dhruvkb for review because of his familiarity with this to begin with, plus I need to make sure that someone on macOS (an arm64 computer, really) tests this.

Testing Instructions

Checkout the branch and run ov j build web && ov j up --force-recreate. Then ov j api/dj generatewaveforms --max_records=2 and confirm that waveforms are successfully generated for 2 audio files. If you already have waveforms for all audio files, you'll need to remove them manually (left up to you) or start over with API test data using ov j down -v && ov j api/init.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Sep 17, 2024
@sarayourfriend sarayourfriend requested a review from a team as a code owner September 17, 2024 07:59
@sarayourfriend sarayourfriend requested review from krysal and stacimc and removed request for a team September 17, 2024 07:59
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and it works. It's nice that we can't eliminate the hacky installation and replace it with a more elegant approach.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works great in my case too. Awesome!

@sarayourfriend sarayourfriend merged commit 2ce799d into main Sep 17, 2024
79 checks passed
@sarayourfriend sarayourfriend deleted the fix/stabilise-audiowaveform-build-api branch September 17, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix audiowaveform isolation issues in API dockerfile
3 participants