Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inverted CC icons for dark mode #4921

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Implement inverted CC icons for dark mode #4921

merged 2 commits into from
Sep 13, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 12, 2024

Fixes

Fixes #4909 by @fcoveram

Description

This PR adds inverted icons for CC licenses. A small cleanup was performed for the added SVGs (such as removing unnecessary attributes and merging paths).

Testing Instructions

  1. Check out the PR and run the dev server.
  2. Search for something to go to the search page.
    • Note the icons.
  3. Switch to dark mode.
  4. Check the following:
    • The license icons in the filters sidebar should be reversed.
    • The license icons in image and audio results should be reversed.
  5. Switch back to light mode.
  6. Click on any media item to go to the single result page.
    • Note icons.
  7. Switch to dark mode.
  8. Check the following:
    • The license icons in the license explanation should be reversed.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 12, 2024 19:53
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 12, 2024
@fcoveram fcoveram self-requested a review September 13, 2024 08:25
Copy link
Contributor

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great 🚀

@fcoveram
Copy link
Contributor

While running dev, I noticed that the switcher's popover is broken. I stop and run dev twice and still see it.

CleanShot.2024-09-13.at.10.28.17.mp4

It has nothing to do with this PR, but wondering if you also see this to report it in a new issue.

@fcoveram
Copy link
Contributor

I was reading about optimizing SVG files for dev hands-off, and discovered SVGOMG.

If you find that useful, I took the time to clean up all the icons.

CC icons in light and dark.zip

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 13, 2024

@fcoveram I already cleaned up the icons in this PR, albeit with a custom hacky Python script. We should definitely incorporate SVGOMG into our workflow.

@dhruvkb dhruvkb changed the title Implement reversed CC icons for dark mode Implement inverted CC icons for dark mode Sep 13, 2024
@dhruvkb dhruvkb merged commit e0a2782 into main Sep 13, 2024
48 checks passed
@dhruvkb dhruvkb deleted the dark_icons branch September 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include a dark version of CC license icons
4 participants