-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ContentSource
to match MediaMixin
#4854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the max_length to 80 to match the higher of the two constraints seems reasonable to me 👍 But don't we need to run makemigrations
here?
Definitely need |
cc3cc52
to
2cce646
Compare
ContentProvider
to match MediaMixin
ContentSource
to match MediaMixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I updated the PR title to correct the model name @obulat, just a heads-up in case you are surprised by it 🙂
I'm pretty confident that this will be a non-problem to apply in production. The table is very small, anyway. Based on the Postgres documentation for varchar, the database will need to adjust the padding on each row for the column, but I'd expect that to be fast. varchar is TOAST, so it doesn't need to change the width of the column within the table anyway.
Signed-off-by: Olga Bulat <[email protected]>
2cce646
to
176c0a3
Compare
This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced. |
Fixes
Fixes #2488 by @sarayourfriend
Description
This PR updates the
ContentProvider.provider_identifier
field length to matchAbstractMedia.provider
(80 characters).Testing Instructions
The CI should pass.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin