Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or ignore deprecation warnings in the catalog #4773

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

AetherUnbound
Copy link
Collaborator

Description

This PR addresses the following deprecation warnings that appear when running the catalog's tests.

dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
dags/common/storage/columns.py:33
  /opt/airflow/catalog/dags/common/storage/columns.py:33: DeprecationWarning: In 3.13 the default `auto()`/`_generate_next_value_` will require all values to be sortable and support adding +1
  and the value returned will be the largest value in the enum incremented by 1
    calculate_value = auto()

tests/dags/common/loader/test_sql.py: 87 warnings
tests/dags/providers/provider_api_scripts/test_inaturalist.py: 1 warning
tests/dags/common/loader/test_s3.py: 34 warnings
  /home/airflow/.local/lib/python3.12/site-packages/botocore/auth.py:419: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    datetime_now = datetime.datetime.utcnow()

tests/dags/common/loader/test_s3.py::test_get_staged_s3_object_finds_object_with_defaults
tests/dags/common/sensors/test_single_run_external_dags_sensor.py::test_fails_if_external_dag_missing_sensor_task
  /home/airflow/.local/lib/python3.12/site-packages/marshmallow_sqlalchemy/convert.py:17: DeprecationWarning: The '__version__' attribute is deprecated and will be removed in in a future version. Use feature detection or 'importlib.metadata.version("marshmallow")' instead.
    _META_KWARGS_DEPRECATED = Version(ma.__version__) >= Version("3.10.0")

The first one is actually resolvable, the latter two just need to be ignored for now.

Testing Instructions

  1. Check out main and run ov just catalog/test and observe the warnings at the end of the output
  2. Check out this branch and run the same and observe that they are no longer present

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner August 16, 2024 18:02
@AetherUnbound AetherUnbound added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Aug 16, 2024
@AetherUnbound AetherUnbound requested review from krysal and stacimc and removed request for a team August 16, 2024 18:02
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning on marshmallow_sqlalchemy is still showing up in CI but I agree on silencing them.

@AetherUnbound
Copy link
Collaborator Author

Thanks for pointing that out @krysal! Should be fixed now, I'll double check before merging.

@AetherUnbound AetherUnbound merged commit 1f28543 into main Aug 19, 2024
41 checks passed
@AetherUnbound AetherUnbound deleted the fix/catalog-warnings branch August 19, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants