Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wikimedia provider when verbose logging enabled #4753

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

stacimc
Copy link
Collaborator

@stacimc stacimc commented Aug 13, 2024

Fixes

Fixes #[issue number] by @[issue author]

Description

Fixes the Wikimedia DAG when running locally with verbose logging enabled. The get_batch_data method was returning dict_values rather than a list, causing an error in the construction of the verbose logs.

Testing Instructions

Optionally, try running the Wikimedia DAG locally on main and verify that you see the "TypeError: 'dict_values' object is not subscriptable" error. Then checkout this branch, run ov j up, and re-run the DAG. The error happens immediately, so you only need to make sure that some records are logged.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Aug 13, 2024
@stacimc stacimc self-assigned this Aug 13, 2024
@stacimc stacimc requested a review from a team as a code owner August 13, 2024 22:32
@stacimc stacimc requested review from krysal and AetherUnbound and removed request for a team August 13, 2024 22:32
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Local run logged appropriately 😄

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes the dag from main ✅ I find it strange that this problem wasn't caught before 🤔 It may warrant an automated test but I need this for #4772, so since @AetherUnbound also approved should be fine.

@krysal krysal merged commit 711f2c5 into main Aug 16, 2024
70 checks passed
@krysal krysal deleted the fix/wikimedia-verbose-logs branch August 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants