Fix Wikimedia provider when verbose logging enabled #4753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #[issue number] by @[issue author]
Description
Fixes the Wikimedia DAG when running locally with verbose logging enabled. The
get_batch_data
method was returningdict_values
rather than a list, causing an error in the construction of the verbose logs.Testing Instructions
Optionally, try running the Wikimedia DAG locally on
main
and verify that you see the"TypeError: 'dict_values' object is not subscriptable"
error. Then checkout this branch, runov j up
, and re-run the DAG. The error happens immediately, so you only need to make sure that some records are logged.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin