Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio collection page SSR error #4722

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 6, 2024

Extract common functionality to a composable

Fixes

Fixes #4721 by @obulat

Description

This PR fixes the audio collection SSR by setting the media to the media from the store (instead of the empty array).

It also extracts the collection functionality into a composable. This reduces the code duplication between the audio/image collection pages.
Another fix in this PR is the re-addition of the creatorUrl prop. This prop was lost when migrating to Nuxt 3, and the creator collections did not have the link to their landing pages on source websites.

Testing Instructions

Run the app.

Search for something in audio, and then click on one of the tags. Refresh the page to see how SSR page looks. On main and in production, the page does not show any results, and there is an error logged in the console. In this PR, the page works correctly. Note that the image collections work well both in production and here.

Check a creator collection page. On main and in production, the page does not have a creator link button in the header. In this PR, the link is shown (both in the image and in the audio page)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat self-assigned this Aug 6, 2024
@obulat obulat requested a review from a team as a code owner August 6, 2024 04:20
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Aug 6, 2024
Extract common functionality to a composable

Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat merged commit 6149929 into main Aug 6, 2024
43 checks passed
@obulat obulat deleted the fix/audio-collection-ssr branch August 6, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Audio collection SSR error
3 participants