Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flake in pages.spec.ts #4709

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix test flake in pages.spec.ts #4709

merged 1 commit into from
Aug 2, 2024

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Aug 2, 2024

Description

Fixes flake in pages.spec.ts by waiting for the route navigation that occurrs after using the locale chooser. This prevents a race condition where the search input would be populated before the route change, and then the route change would reset the search query

Testing Instructions

All CI should pass.

Additionally, you can build and start the frontend with ov j frontend/run build && ov j frontend/run start, then run Playwright interactively and locally with just frontend/run test:playwright:local -- --ui pages.spec.ts. Press the green play arrow next to the "layout color is set correctly" test to run it.

The test should pass or make it through to the end and fail with a small screenshot difference in text rendering based on differences between your local system and the CI 😅

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Fixes flake in pages.spec.ts by waiting for the route navigation that occurrs after using the locale chooser. This prevents a race condition where the search input would be populated before the route change, and then the route change would reset the search query
@zackkrida zackkrida requested a review from a team as a code owner August 2, 2024 18:34
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 2, 2024
@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 2, 2024
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🤞🏼

@zackkrida zackkrida merged commit b74d8b0 into main Aug 2, 2024
72 of 82 checks passed
@zackkrida zackkrida deleted the really-fix-test-flake branch August 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants