Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django admin views for bulk moderation ergonomics #4673

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jul 30, 2024

Fixes

Fixes #3842 by @stacimc
Fixes #3843 by @stacimc
Fixes #3844 by @stacimc

Description

  1. This PR adds a filter by decision ID to the sidebar of the sensitive media and deleted media list views. Using this filter the list can be quickly narrowed down to all the meida affected by one decision, making it easier to operate on them again, as a bulk.

    image

  2. This PR also updates the decision list view to add a single/bulk decision filter.

    image

  3. Finally the PR links to the sensitive media or deleted media list views from the single decision page, automatically populating the filter parameter described in point 1 above.

Screenshot 2024-07-30 at 9 54 55 PM

Testing Instructions

  1. Check out the PR and run the dev server.
  2. Create some reports and take decisions on them from the single media view or take decisions on media items directly using bulk moderation actions from the media list view.
  3. Go to the sensitive media list and filter by a decision ID. You should only UUIDs for media that were affected by that decision.
  4. Go to the deleted media list and filter by a decision ID. You should only see UUIDs for media that were affected by that decision.
  5. Go the decision list view. Filter the decisions by single or bulk. Based on your actions in step 1, you will see a subset of decisions.
  6. Click on a deindexing decision, you will see a "View deleted" button in top right, clicking which takes you to the pre-filtered deleted media list view.
  7. Click on a sensitive marking decision, you will see a "View sensitive" button in the top right, clicking which tkaes you to the pre-filtered sensitive media list view.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested review from a team as code owners July 30, 2024 17:11
@dhruvkb dhruvkb requested review from AetherUnbound, obulat and krysal and removed request for a team July 30, 2024 17:11
@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Jul 30, 2024
@dhruvkb dhruvkb changed the title Add filter to filter sensitive and deleted media by decision ID Enable filtering sensitive and deleted media by decision ID Jul 30, 2024
@dhruvkb dhruvkb changed the title Enable filtering sensitive and deleted media by decision ID Update Django admin views for bulk moderation ergonomics Jul 30, 2024
@AetherUnbound AetherUnbound removed their request for review July 30, 2024 19:29
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Minor comments (you've already addressed one of my typical comments favoring verbosity over potentially-ambiguous brevity), but LGTM.

@dhruvkb dhruvkb merged commit 8caa0e2 into main Jul 31, 2024
46 checks passed
@dhruvkb dhruvkb deleted the bulk_admin_views branch July 31, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
3 participants