-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django admin views for bulk moderation ergonomics #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
requested review from
AetherUnbound,
obulat and
krysal
and removed request for
a team
July 30, 2024 17:11
openverse-bot
added
🧱 stack: api
Related to the Django API
🟨 priority: medium
Not blocking but should be addressed soon
🌟 goal: addition
Addition of new feature
💻 aspect: code
Concerns the software code in the repository
labels
Jul 30, 2024
dhruvkb
changed the title
Add filter to filter sensitive and deleted media by decision ID
Enable filtering sensitive and deleted media by decision ID
Jul 30, 2024
dhruvkb
changed the title
Enable filtering sensitive and deleted media by decision ID
Update Django admin views for bulk moderation ergonomics
Jul 30, 2024
8 tasks
zackkrida
reviewed
Jul 31, 2024
zackkrida
reviewed
Jul 31, 2024
Co-authored-by: zack <[email protected]>
zackkrida
reviewed
Jul 31, 2024
zackkrida
reviewed
Jul 31, 2024
zackkrida
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Minor comments (you've already addressed one of my typical comments favoring verbosity over potentially-ambiguous brevity), but LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
🌟 goal: addition
Addition of new feature
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: api
Related to the Django API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3842 by @stacimc
Fixes #3843 by @stacimc
Fixes #3844 by @stacimc
Description
This PR adds a filter by decision ID to the sidebar of the sensitive media and deleted media list views. Using this filter the list can be quickly narrowed down to all the meida affected by one decision, making it easier to operate on them again, as a bulk.
This PR also updates the decision list view to add a single/bulk decision filter.
Finally the PR links to the sensitive media or deleted media list views from the single decision page, automatically populating the filter parameter described in point 1 above.
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin