Remove the "2 Reviews Needed" column automation from the PR board

[zackkrida]

Description

This PR removes JavaScript logic from the automations/js/src/project_automation/prs.mjs file which moves cards into the "Needs 2 Reviews" column of our PR project board.

-  } else {
-   await prBoard.moveCard(prCard.id, prBoard.columns.Needs2Reviews)
-  }

This PR also updates the entire file to conform to our prettier config.

Testing Instructions

Review the logic and hope it works!

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

@dhruvkb is the reasoning for your suggestions that having 1 approving review is the same as being "APPROVED", now? I just want to make sure I understand how this is working; thanks!

[dhruvkb]

Yeah, that's exactly it @zackkrida. PRs with one approval will already have reviewDecision === "APPROVED" and we need to send PRs to "Needs 1 Review" by default if they don't fulfill any of the other conditions.

[AetherUnbound]

LGTM!

[obulat]

The logic looks correct now.
We could rename the column to "Needs review" instead of "Needs 1 review" for brevity.

How did the file pass the linting step in CI before? Are these files not linted?

[obulat]

The logic looks correct now.
We could rename the column to "Needs review" instead of "Needs 1 review" for brevity.

How did the file pass the linting step in CI before? Are these files not linted?
The PR is failing the linting check. Do we use a different set of rules for these files?

Adding mjs here should fix the CI error:

openverse/.pre-commit-config.yaml

Line 128 in b96fc34

files: (frontend|automations|packages/js).*?\.(js|ts|vue|json5|json)$

[dhruvkb]

@obulat automations have their separate Prettier config file for some reason.

[obulat]

@obulat automations have their separate Prettier config file for some reason.

Great find! I guess we need to update the pre-commit to include mjs, and remove this prettier config.

[zackkrida]

Thanks for the suggestions! I've now:

• Removed the dedicated prettier config for automations
• Added mjs files to the precommit eslint hook
• Fixed all of the mjs automations

As for the actual code itself:

• Renamed the column on the board to "Needs Review"
• Removed the "Needs 2 Reviews" column
• Updated the code to reference the "Needs Review" column

I'll merge once CI passes.