Specify pull policy for openverse-
images
#4568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
pull_policy
ofnever
for custom Openverse images that are meant to be built on-deviceremoves the(this had to be reversed because ingestion server integration tests would fail)image
field for services where the image name is the same as the defaultopenverse-<service_name>
Effectively, these changes mean that the warning referenced in #4526 (comment) will go away.
This will be further expanded by #1910 which will expand the second change to apply to more services.This also makes it safer by ensuring that we never accidentally pull a (potentially nefarious) image named
openverse-*
from the Docker registry.Testing Instructions
openverse-*
images from Docker.just up
.Checklist
Update index.md
).main
) or a parent feature branch../ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
./ov just catalog/generate-docs media-props
for the catalog or
./ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin