Fix flaky VCollectionHeader snapshot tests #4559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4558 by @sarayourfriend
Description
Copied from the issue, where I discovered the underlying problem:
That turned out to be it, exactly. I manually updated these ones by setting
maxPixelDiffRatio
to 0 for the VCollectionHeader tests. I will open an issue after finishing this PR description to dig into smarter ways of configuringmaxPixelDiffRatio
that are aware of things like our varying screen sizes and the effect that might have on things.It might mainly affect only the storybook visual regression tests because they are so much smaller overall? Anyway, something to think about in the other issue, not here. For now, I just want to fix the flaky test by updating these snapshots to have the correct text.
Testing Instructions
CI must pass. Confirm the updated screenshots use the correct text and look right otherwise.
Checklist
Update index.md
).main
) or a parent feature branch../ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
./ov just catalog/generate-docs media-props
for the catalog or
./ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin