Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use unstable pook reference for API #4536

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Do not use unstable pook reference for API #4536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc779e0
Do not use unstable pook reference for API
sarayourfriend Jun 21, 2024
9172c1d
Fix number of times bad response is mocked (one was missing)
sarayourfriend Jun 25, 2024
f504034
Remove unneeded git dependency
sarayourfriend Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ENV PIP_NO_COLOR=1
# - Create a virtualenv inside `/venv`
# - Install PDM to install Python dependencies
RUN apt-get update \
&& apt-get install -y python3-dev git \
&& apt-get install -y python3-dev \
&& rm -rf /var/lib/apt/lists/* \
&& pip install pdm~=2.14

Expand Down
9 changes: 5 additions & 4 deletions api/pdm.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ test = [
"factory-boy >=3.3.0, <4",
"fakeredis >=2.21.3, <3",
"freezegun >=1.4.0, <2",
"pook @ git+https://github.com/h2non/pook.git@master",
"pook >=1.4.3, <2",
"pytest >=7.4.4, <8",
"pytest-django >=4.8.0, <5",
"pytest-pook>=1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion api/test/unit/utils/test_image_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def test_caches_failures_if_cache_surpasses_tolerance(mock_image_data, settings,
)
.header("User-Agent", UA_HEADER)
.header("Accept", "image/*")
.times(tolerance)
.times(tolerance + 1)
.reply(401)
.body(MOCK_BODY)
)
Expand Down