Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'updated_on' column during popularity refresh #4460

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Jun 6, 2024

Fixes

Description

When records are updated as part of a popularity refresh, the updated_on column is not updated. This PR changes that.

It also updates the batched_update DAG to set the default update_query to include the updated_on update.

Testing Instructions

Run a popularity refresh locally, ensure that it passes and that the updated_on column is updated.

Trigger a batched_update and verify that the default update_query is SET updated_on = NOW(), .... Verify that you can run a batched_update with some additional query. Verify that if you try again but remove that part from the update_query, you get a validation error in the UI.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🧱 stack: catalog Related to the catalog and Airflow DAGs 🗄️ aspect: data Concerns the data in our catalog and/or databases labels Jun 6, 2024
@stacimc stacimc self-assigned this Jun 6, 2024
@stacimc stacimc requested a review from a team as a code owner June 6, 2024 23:29
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to set the updated_on in the batched_update? That would make it easier to update this field whenever the batched_update is run

@stacimc
Copy link
Contributor Author

stacimc commented Jun 7, 2024

Yes, this PR came up in conversation on #4429 (comment) where I noted that batched updates don't automatically set this either. My intention here is to fix it in the established DAGs while we think about a more permanent solution (likely a trigger). I'll add a change for the batched_update as well though!

@stacimc stacimc mentioned this pull request Jun 7, 2024
7 tasks
@stacimc stacimc marked this pull request as draft June 7, 2024 16:29
@stacimc stacimc marked this pull request as ready for review June 7, 2024 16:37
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! Nice that Airflow has a pattern verification functionality

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stacimc stacimc merged commit d0c0226 into main Jun 13, 2024
52 checks passed
@stacimc stacimc deleted the update/updated_on_col_in_popularity_refresh branch June 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄️ aspect: data Concerns the data in our catalog and/or databases 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants