Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove popularity & matview timeouts from data refresh configurations #4353

Merged
merged 1 commit into from
May 19, 2024
Merged

Remove popularity & matview timeouts from data refresh configurations #4353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions catalog/dags/legacy_data_refresh/data_refresh_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,6 @@ class DataRefresh:
airflow.dag.DAG __init__ method.
data_refresh_timeout: timedelta expressing the amount of time the data
refresh (run by the ingestion server) may take.
refresh_metrics_timeout: timedelta expressing amount of time the
refresh popularity metrics tasks may take.
refresh_matview_timeout: timedelta expressing amount of time the
refresh of the popularity matview may take.
create_pop_constants_view_timeout: timedelta expressing amount of time the
creation of the popularity constants view
may take
create_materialized_view_timeout: timedelta expressing amount of time the
creation of the matview may take
index_readiness_timeout: timedelta expressing amount of time it may take
to await a healthy ES index after reindexing
doc_md: str used for the DAG's documentation markdown
Expand All @@ -60,10 +51,6 @@ class DataRefresh:
schedule: str | None = "0 0 * * 1" # Mondays 00:00 UTC
default_args: dict = field(default_factory=dict)
data_refresh_timeout: timedelta = timedelta(days=1)
refresh_metrics_timeout: timedelta = timedelta(hours=1)
refresh_matview_timeout: timedelta = timedelta(hours=1)
create_pop_constants_view_timeout: timedelta = timedelta(hours=1)
create_materialized_view_timeout: timedelta = timedelta(hours=1)
create_filtered_index_timeout: timedelta = timedelta(days=1)
index_readiness_timeout: timedelta = timedelta(days=1)
data_refresh_poke_interval: int = REFRESH_POKE_INTERVAL
Expand All @@ -78,10 +65,6 @@ def __post_init__(self):
IMAGE: DataRefresh(
media_type="image",
data_refresh_timeout=timedelta(days=4),
refresh_metrics_timeout=timedelta(hours=24),
refresh_matview_timeout=timedelta(hours=72),
create_pop_constants_view_timeout=timedelta(hours=24),
create_materialized_view_timeout=timedelta(hours=72),
data_refresh_poke_interval=int(os.getenv("DATA_REFRESH_POKE_INTERVAL", 60)),
filtered_index_poke_interval=int(
os.getenv("DATA_REFRESH_POKE_INTERVAL", 60 * 30)
Expand Down
Loading