Initialize feature flag state on the server #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
obulat
added
🟨 priority: medium
obulat
force-pushed
the
fix/evaluate-feature-flag-at-init
branch
3 times, most recently
from
909d75f
to
839da3d
Compare
dhruvkb
approved these changes
May 13, 2024
obulat
force-pushed
the
fix/evaluate-feature-flag-at-init
branch
from
839da3d
to
bc36749
Compare
sarayourfriend
requested changes
May 14, 2024
There was a problem hiding this comment.
LGTM, but one small blocker on the test setup/cleanup when modifying process.env. It's a blocker because the environment for those tests will leak into others if they themselves fail, potentially causing false-positives/negatives which would be confusing when debugging the specific failure of either of those two tests.
| @@ -8,8 +8,8 @@ | |||
| it doesn't count as a user preference. | |||
| --> | |||
| <div | |||
| v-for="(group, groupIndex) in featureData.groups" | |||
| :key="groupIndex" | |||
There was a problem hiding this comment.
Oof! Good catch to change this to a stable value 😰
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/evaluate-feature-flag-at-init
branch
from
bc36749
to
53014e4
Compare
sarayourfriend
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4223 by @obulat
Description
This PR sets the flag states on the server init based on the
DEPLOYMENT_ENVenv variable, instead of checking the state every time we access the flag.The filtering of flags by switchable or by feature groups was moved to the store, too, to simplify the component code.
Testing instructions
The CI checks preferences and sensitive toggle, so the CI passing is a good indicator.
Go to
/preferencesand see that the features are displayed correctly and can be toggled.