-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook smoke test #4265
Add storybook smoke test #4265
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/4265 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
7bbc506
to
2528a0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks find, I can't comment much on the Storybook pieces or the discussion the team has been having about its usage. It looks like it passes in CI but when I try to run it locally I get the following (seems worth noting since they all happen on the same component):
playwright-1 | 18 failed
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint 2xl with width 1536 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xl with width 1280 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint lg with width 1024 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint md with width 768 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint sm with width 640 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xs with width 340 › should render a rtl media reuse section with "Rich Text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint 2xl with width 1536 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xl with width 1280 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint lg with width 1024 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint md with width 768 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint sm with width 640 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xs with width 340 › should render a rtl media reuse section with "HTML" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint 2xl with width 1536 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xl with width 1280 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint lg with width 1024 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint md with width 768 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint sm with width 640 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | visual-regression/v-media-reuse.spec.ts:30:13 › VMediaReuse › screen at breakpoint xs with width 340 › should render a rtl media reuse section with "Plain text" tab open
playwright-1 | 281 passed (5.8m)
playwright-1 | ELIFECYCLE Command failed with exit code 1.
Interesting. If you could upload one of the |
Aaaaaand everything is passing today 😅 Sorry about the false alarm! |
Awesome! A false alarm is much better than having to debug yet another storybook CI failure, thank you, @AetherUnbound :) |
2528a0e
to
718d2a8
Compare
718d2a8
to
6a6bc63
Compare
Signed-off-by: Olga Bulat <[email protected]>
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was ready for review 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Fixes #2219
Description
This PR adds a
smoke-test
to storybook tests. This test iterates over the Storybook sections, opens each page and checks if there are any console logs or warnings that are signs of broken stories.Some stories were missing props or store setup steps.
Some component stories were using old no-longer-existing variants (e.g.,
size
for full layout ofVAudioTrack
)Testing instructions
See the first commit's CI logs in this PR to see sample error display:
The error log
In the second commit, all the problems will be fixed, and the CI logs should not show any problems