Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Science Museum index out of range error #4253

Merged
merged 1 commit into from
May 1, 2024

Conversation

stacimc
Copy link
Collaborator

@stacimc stacimc commented May 1, 2024

Fixes

Fixes production error. Blocking on Science Museum full run, needed to enable the provider in production.

Description

(Hopefully last) small fix for Science Museum to try to get a complete dagrun. Handles case where the record data contains no licensing information.

Testing Instructions

Run the Science Museum DAG with:

"initial_query_params":{
  "date[from]":1915,
  "date[to]":1925,
  "has_image":1,
  "image_license":"CC",
  "page[number]":11,
  "page[size]":100
}

This should error immediately on main but pass on this branch.

Note that if you want to test the full DAG you need to have the admin variable SKIPPED_INGESTION_ERRORS configured with this value:

{
    "science_museum_workflow": [
        {
            "issue": "https://github.com/WordPress/openverse/issues/4013",
            "predicate": "Service unavailable for url"
        }
    ]
}

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md`).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (only applicable for catalog PRs).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or
(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or
(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.
(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels May 1, 2024
@stacimc stacimc self-assigned this May 1, 2024
@stacimc stacimc requested a review from a team as a code owner May 1, 2024 17:51
@stacimc stacimc requested review from AetherUnbound and obulat May 1, 2024 17:51
@stacimc stacimc marked this pull request as draft May 1, 2024 17:54
@stacimc
Copy link
Collaborator Author

stacimc commented May 1, 2024

Drafting while I test that I can get a full run locally. (Update: I was able to run the DAG to completion with this applied).

@stacimc stacimc marked this pull request as ready for review May 1, 2024 18:16
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stacimc stacimc merged commit 7ff92d2 into main May 1, 2024
73 checks passed
@stacimc stacimc deleted the fix/science-museum-empty-rights branch May 1, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants