-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete field from docker-compose.yml #4200
Conversation
This is related to #4046, and it seems there may be some other work that's necessary in order to close that issue. |
@AetherUnbound Can you specify what additional work is needed based on the issue? If this PR works in CI and locally, then I think we're good to go. There was some speculation that the compose file version changes might affect our existing usage, but it seems like they didn't 🤔 we were only using forward compatible features? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CI passing is a good indication we're good to go here. Things work for me locally too, as far as I can tell!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because CI passes.
from django.conf import settings | ||
from django.conf.urls.static import static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, unused imports are not caught in __init__.py
. Good catch, @krysal!
This was my only concern, based on the language you used in the other issue. |
Description
Every time a
just
command involving docker is run, you get a warning:According to documentation, it can be safely removed.
This PR also removes some unused imports from the file defining API URLs.
Testing Instructions
Compare this branch with
main
looking at the output of thejust api/up
, for example.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin