-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show sources if their count has not changed #4176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for @krysal's suggestions. Do we need to handle a case where all sources are unchanged? That seems unlikely to ever occur at all.
Only in local testing I would imagine! I don't think it's worth having logic for that case, personally. And I've made the message about unchanged sources ambiguous enough that it should cover the case where all sources are absent too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Follow-up to #4067
Here's the report from the most recent audio data refresh:
The current logic is set to show all sources, regardless of whether there was a change or not. This PR changes the logic so only sources that have increased or decreased in size are shown in the final report. While this doesn't have a huge effect on audio data refreshes, it will for image data refreshes since we have significantly more sources there.
Testing Instructions
Updated tests should pass. Alternatively, run the data refresh locally after
just api/init
and see that no sources are listed in the completion message because none of the counts changed.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin