-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest packages #4048
Update jest packages #4048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
// afterEach(() => { | ||
// apiService = undefined | ||
// }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests pass, just delete it 👍
I don't remember why I put this here and can't tell what it would meaningfully do 🤷
@@ -60,8 +60,8 @@ | |||
</li> | |||
</template> | |||
|
|||
<script lang="ts"> | |||
import { computed, defineComponent, PropType } from "vue" | |||
<script setup lang="ts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looking forward to script setup
!
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Fixes
Fixes #4047 by @obulat
Description
This PR updates jest and jest-related packages (babel-, testing library).
To test that this allows
script setup
in components, I convertedVImageCell
toscript setup
. This also showed that there is an unused function,getImageForeignUrl
, which is removed in this PR.I also commented out
mockCreateApiService
'safterEach
because it causes the following error:Error: Hooks cannot be defined inside tests. Hook of type "afterEach" is nested within "should save the token into the process and inject into the context".
This did not change the test results. I don't completely understand the setup there, would removingafterEach
be okay, @sarayourfriend ?Testing Instructions
The unit tests in the CI should pass.
The image search results (both images and all results search views) should work correctly and not show additional warnings.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin