Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest packages #4048

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Update jest packages #4048

merged 3 commits into from
Apr 8, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 8, 2024

Fixes

Fixes #4047 by @obulat

Description

This PR updates jest and jest-related packages (babel-, testing library).

To test that this allows script setup in components, I converted VImageCell to script setup. This also showed that there is an unused function, getImageForeignUrl, which is removed in this PR.

I also commented out mockCreateApiService'safterEach because it causes the following error: Error: Hooks cannot be defined inside tests. Hook of type "afterEach" is nested within "should save the token into the process and inject into the context". This did not change the test results. I don't completely understand the setup there, would removing afterEach be okay, @sarayourfriend ?

Testing Instructions

The unit tests in the CI should pass.
The image search results (both images and all results search views) should work correctly and not show additional warnings.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat self-assigned this Apr 8, 2024
@obulat obulat requested a review from a team as a code owner April 8, 2024 06:34
@obulat obulat requested review from AetherUnbound and dhruvkb April 8, 2024 06:34
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Apr 8, 2024
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Apr 8, 2024
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

Comment on lines 65 to 67
// afterEach(() => {
// apiService = undefined
// })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, just delete it 👍

I don't remember why I put this here and can't tell what it would meaningfully do 🤷

@@ -60,8 +60,8 @@
</li>
</template>

<script lang="ts">
import { computed, defineComponent, PropType } from "vue"
<script setup lang="ts">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to script setup!

@obulat obulat merged commit cd74e8a into main Apr 8, 2024
39 checks passed
@obulat obulat deleted the update-jest branch April 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update jest to the newest version
4 participants