-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SEARCH_RESPONSE_TIME
event
#4044
Conversation
e8d129e
to
278b575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Now that Plausible supports filtering on more than one custom property, we could combine these into a single event with a mediaType
attribute, but up to you.
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
I updated the PR to combine the two events into one. |
Signed-off-by: Olga Bulat <[email protected]>
278b575
to
ef4d26d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Fixes #3775 by @obulat
Fixes #2471 by @sarayourfriend
Description
This PR re-adds the old PR.
It is not possible to call
useContext
in the media service because there is no Vue instance available there. This is why I rewrote the code to return the parameters to the store, together with the response data. Then, in the store, we usethis.$nuxt.$sendCustomEvent
to send the event with the returned parameters.Testing Instructions
Try making searches and viewing tag/source/creator pages. You should see the search time events logged in the console.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin