Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEARCH_RESPONSE_TIME event #4044

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Add SEARCH_RESPONSE_TIME event #4044

merged 4 commits into from
Apr 9, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 5, 2024

Fixes

Fixes #3775 by @obulat
Fixes #2471 by @sarayourfriend

Description

This PR re-adds the old PR.

It is not possible to call useContext in the media service because there is no Vue instance available there. This is why I rewrote the code to return the parameters to the store, together with the response data. Then, in the store, we use this.$nuxt.$sendCustomEvent to send the event with the returned parameters.

Testing Instructions

Try making searches and viewing tag/source/creator pages. You should see the search time events logged in the console.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner April 5, 2024 12:47
@obulat obulat requested review from AetherUnbound and dhruvkb April 5, 2024 12:47
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Apr 5, 2024
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Apr 5, 2024
@obulat obulat force-pushed the add/SEARCH_RESPONSE_TIME-event branch 2 times, most recently from e8d129e to 278b575 Compare April 8, 2024 09:50
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Now that Plausible supports filtering on more than one custom property, we could combine these into a single event with a mediaType attribute, but up to you.

adjeiv and others added 3 commits April 9, 2024 07:02
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat
Copy link
Contributor Author

obulat commented Apr 9, 2024

Awesome! Now that Plausible supports filtering on more than one custom property, we could combine these into a single event with a mediaType attribute, but up to you.

I updated the PR to combine the two events into one.

@obulat obulat force-pushed the add/SEARCH_RESPONSE_TIME-event branch from 278b575 to ef4d26d Compare April 9, 2024 04:12
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obulat obulat merged commit 54d26f1 into main Apr 9, 2024
41 checks passed
@obulat obulat deleted the add/SEARCH_RESPONSE_TIME-event branch April 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SEARCH_TIME_EVENT is unusable due to plausible and CORS limitations Add SEARCH_RESPONSE_TIME analytics event
5 participants