-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related endpoint error is still sent to Sentry #4009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, @jeevikasirwani ! I added a suggestion inline to completely delete the line instead of commenting it out.
Could you please also fill in the PR description - without it the PR automations do not work.
Co-authored-by: Olga Bulat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the PR description and testing instructions.
Thank you for your contribution, @jeevikasirwani !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jeevikasirwani 🙂
Fixes
Fixes #4006 by @obulat
Description
This PR removes the line that sends network error to sentry on related endpoint. This line was accidentally left in code in #3850.
Testing Instructions
First, try these instructions on
main
branch, and then re-run them in this branch.On
main
, you should see the analytics and the sentry log in the browser console. Here, there should only be the analytics log, nothing should be logged for sentry.logMockCalls
in sentry config totrue
:openverse/frontend/src/utils/sentry-config.ts
Line 10 in 2bd852c
just frontend/run dev
offline
. The related images shouldn't load, and you can see analytics and/or sentry logs in the browser console.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin