Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo height #3967

Merged
merged 13 commits into from
Mar 27, 2024
5 changes: 1 addition & 4 deletions frontend/src/components/VHeader/VLogoButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@
icon-only
class="text-dark-charcoal hover:bg-yellow"
>
<VLogoLoader
:status="isFetching ? 'loading' : 'idle'"
:auto-resize="false"
/>
<VLogoLoader :status="isFetching ? 'loading' : 'idle'" />
</VButton>
</template>
<script>
Expand Down
8 changes: 1 addition & 7 deletions frontend/src/components/VLogoLoader/VLogoLoader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
xmlns="http://www.w3.org/2000/svg"
:class="{
loading: status === 'loading' && !prefersReducedMotion,
'h-10 w-10': autoResize,
'h-12 w-12': !autoResize,
}"
aria-hidden="true"
:data-prefers-reduced-motion="prefersReducedMotion"
data-testid="logo-loader"
class="inline-flex items-center justify-center rounded p-3 md:h-12 md:w-12"
class="inline-flex h-4.5 items-center justify-center rounded"
fill="currentColor"
>
<path
Expand Down Expand Up @@ -52,10 +50,6 @@ export default defineComponent({
type: String as PropType<"loading" | "idle">,
default: "idle",
},
autoResize: {
type: Boolean,
default: true,
},
},
setup() {
const prefersReducedMotion = useReducedMotion()
Expand Down
6 changes: 0 additions & 6 deletions frontend/test/playwright/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ const config: PlaywrightTestConfig = {
* Playwright default of using 1/2 of the number of CPU cores continues to work otherwise.
*/
workers: UPDATE_TAPES === "true" ? 1 : undefined,
expect: {
toMatchSnapshot: {
// If the visual regression tests are flaky, we can increase this to 0.1 or 0.2.
maxDiffPixelRatio: 0.01,
},
},
}

export default config
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.