-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collection pages fetching and make them crawlable #3886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
🏷 status: label work required
Needs proper labelling before it can be worked on
labels
Mar 8, 2024
obulat
added
🛠 goal: fix
Bug fix
🕹 aspect: interface
Concerns end-users' experience with the software
🟨 priority: medium
Not blocking but should be addressed soon
and removed
🏷 status: label work required
Needs proper labelling before it can be worked on
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Mar 8, 2024
obulat
force-pushed
the
refactor/search-results
branch
from
March 12, 2024 12:21
ca77dc1
to
3db9e99
Compare
obulat
force-pushed
the
refactor/collection-page
branch
from
March 12, 2024 12:22
9b7a10e
to
628e5f8
Compare
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
refactor/search-results
branch
from
March 14, 2024 17:40
3db9e99
to
5e7c35a
Compare
Handle fetching in `collection.vue` page, and replace `VCollectionPage` with `VCollectionResults` Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
refactor/collection-page
branch
from
March 14, 2024 17:43
3e5f066
to
3f2cc27
Compare
This was referenced Mar 14, 2024
obulat
force-pushed
the
refactor/search-results
branch
from
March 15, 2024 18:16
5e7c35a
to
1f81365
Compare
Joined with #3835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🕹 aspect: interface
Concerns end-users' experience with the software
🛠 goal: fix
Bug fix
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle fetching in
collection.vue
page, and replaceVCollectionPage
withVCollectionResults
Fixes
Fixes #3576 by @AetherUnbound
Fixes #3830 by @obulat
Description
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin