-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accesstoken and ThrottledApplication to admin panel #3836
Add accesstoken and ThrottledApplication to admin panel #3836
Conversation
Co-authored-by: Tore Nylén <[email protected]> Co-authored-by: Oozna <[email protected]> Co-authored-by: Sam Shahriari <[email protected]> Co-authored-by: Sam <[email protected]>
eb27147
to
852dd0a
Compare
Dhruv and I are at WordCamp Asia next week, so pinging @WordPress/openverse-api to reassign reviews on this to folks who are available. Regarding the editable fields, please make I'm not 100% sure how revoking access would work. Deleting the ThrottledApplication instance doesn't seem like the right way to go (just thinking of that being an option), but if we had a new rate limit model called |
Hi @bjornthiberg, Openverse maintainers are going to take a look at your PR this week! Thank you for the contribution 🎉 I did want to make sure you saw the notes from @sarayourfriend concerning editable fields. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I have one code request change, in addition to Sara's note about editable fields above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting this @bjornthiberg. I'm adding just a quick comment to the previous reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for working on this, @bjornthiberg and Co 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and works well locally, thanks for addressing all the changes!
Fixes
Fixes #3711 by @AetherUnbound
Description
This PR adds
oauth_provider.models.AccessToken
andapi.models.oauth.ThrottledApplication
tables to the Django Admin UI.All fields are set as read-only. We are not sure if this is done in the best way. Also, in the issue (#3711), it was said that:
We did not know which fields should be set as editable. Hence the draft PR.
Testing Instructions
Test by opening the Django admin panel and looking at the new entries in the sidebar.
Checklist
Update index.md
).main
) or a parent feature branch.I added or updated tests for the changes I made (if applicable).I added or updated documentation (if applicable).I ran the DAG documentation generator (if applicable).Developer Certificate of Origin
Developer Certificate of Origin