Add the ToS to the navigation bar

[AetherUnbound]

Fixes

Fixes #3564 by @AetherUnbound

Description

This PR adds a link to the Terms of Service (using the name "Terms") to the navigation bar. This is a stopgap measure while we do a larger reorganization of the navigation menu.

There might be something else I'm missing with this PR, frontend folks - please let me know if that's the case!

Testing Instructions

I've updated the playwright snapshots. I think I've done everything that's necessary for testing!

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

Awesome PR with updated snapshots 🎉
You will also need to update the storybook snapshots that test header and footer in isolation. just frontend/run test:storybook -u is probably the command that does so.

[AetherUnbound]

Thanks @obulat for that tip! I'll add it to the frontend documentation on testing as well (that's what I was following 😄)

[AetherUnbound]

I'm...not sure how to proceed now 😅

[sarayourfriend]

@AetherUnbound What are you stuck on? The failing Playwright test in CI might be a flaky test failure, in which case follow this from the comment above.

[dhruvkb]

I can't see any difference in frontend/test/storybook/visual-regression/v-image-cell.spec.ts-snapshots/v-image-cell-intrinsic-focused-xl-linux.png but if CI passes then it's okay I guess?

Might I suggest two explorations?

• updating this PR branch with main
• dropping that file from the PR and seeing if tests continue to pass

[AetherUnbound]

I was able to rebase on main, but re-running storybook locally is adding even more changes that don't seem like they're significant 😕 The fact that CI is passing here on main after a rebase makes me think things are fine, so I'm just going to merge this!