Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use unsupported folded chomping multiline YAML block syntax #3702

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Do not use unsupported folded chomping multiline YAML block syntax #3702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/pr_limit_reminders.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,11 @@ jobs:
id: slack
uses: slackapi/[email protected]
with:
# The JSON below looks malformed, with an invalid multiline string, but YAML's `>`
# construct replaces linebreaks with a space, so the multiline string below will end
# up as a single-line string. The payload will be `{ "user": "...", "message": "..." }
payload: >
# Note: We cannot use the YAML folded chomping block syntax here (`>`) because
# GitHub Actions does not support it (they only support a subset of YAML):
# https://github.com/actions/runner/issues/418#issuecomment-612928525
payload: |
{
"user": "${{ env.slack_id }}",
"message":
"Hi, Opener! \n
You currently have ${{ env.pr_count }} Pull Request(s) open with requested
reviews (totalling ${{ env.required_review_count }} required reviews). \n
To help ease the review burden, increase review velocity for older PRs, and
improve the equitable distribution of project maintenance tasks across the team,
please consider reviewing this list of ways to contribute instead of working on
new code contributions: \n
https://docs.openverse.org/meta/maintainer_tasks.html"
"message": "Hi, Opener! \n You currently have ${{ env.pr_count }} Pull Request(s) open with requested reviews (totalling ${{ env.required_review_count }} required reviews). \n To help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \n https://docs.openverse.org/meta/maintainer_tasks.html"
}
Loading