Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @playwright/test to v1.40.1 #3615

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 2, 2024

Fixes

This is an alternative version of the Renovate PR (#3605), based on #3614

Description

This PR updates the Playwright version to 1.40.1, and makes the necessary changes for the tests to pass.

Some saved responses (tapes) needed to be updated.
In some visual regression tests, there are differences of 1 or 2 pixels. See the red "diff" dot at the top of the Public Domain Mark icon:
Screenshot 2024-01-02 at 1 55 54 PM
I updated the maxDiffPixels for those specific tests so we don't have to update snapshots.

This PR does some housekeeping (lower-casing some test titles to match the others, swapping around describe and breakpoints blocks to make the test logging consistent, adding parallel mode to speed up tests)

Also, since the new Playwright uses a newer node version, I updated the storybook command to make it work.

Testing Instructions

The CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Jan 2, 2024
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jan 2, 2024
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 2, 2024
@obulat obulat self-assigned this Jan 2, 2024
@obulat obulat marked this pull request as ready for review January 2, 2024 16:08
@obulat obulat requested a review from a team as a code owner January 2, 2024 16:08
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App runs locally and the changes make sense, thank you for taking care of this 😄

Base automatically changed from refactor/playwright-tests to main January 4, 2024 02:31
obulat added 5 commits January 4, 2024 10:28
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat force-pushed the update/playwright branch from a22804b to d301685 Compare January 4, 2024 07:30
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obulat obulat merged commit 7373770 into main Jan 4, 2024
39 checks passed
@obulat obulat deleted the update/playwright branch January 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants