-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @playwright/test to v1.40.1 #3615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
label
Jan 2, 2024
obulat
added
🟧 priority: high
Stalls work on the project or its dependents
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
and removed
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Jan 2, 2024
1 task
AetherUnbound
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App runs locally and the changes make sense, thank you for taking care of this 😄
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
update/playwright
branch
from
January 4, 2024 07:30
a22804b
to
d301685
Compare
krysal
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟧 priority: high
Stalls work on the project or its dependents
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This is an alternative version of the Renovate PR (#3605), based on #3614
Description
This PR updates the Playwright version to 1.40.1, and makes the necessary changes for the tests to pass.
Some saved responses (tapes) needed to be updated.
In some visual regression tests, there are differences of 1 or 2 pixels. See the red "diff" dot at the top of the Public Domain Mark icon:
I updated the
maxDiffPixels
for those specific tests so we don't have to update snapshots.This PR does some housekeeping (lower-casing some test titles to match the others, swapping around
describe
andbreakpoints
blocks to make the test logging consistent, addingparallel
mode to speed up tests)Also, since the new Playwright uses a newer node version, I updated the storybook command to make it work.
Testing Instructions
The CI should pass.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin